Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35103 )
Change subject: [WIP] mb/intel/cannonlake_rvp,coffeelake_rvp: Add LPC_TPM
......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
I am waiting for Subrata to tell if these boards have LPC signals routed such that LPC_TPM would ever be possible. Error might be in devicetree.cb instead.
yes, we could connect LPC TPM om this boards but it also need change in descriptor, just CB changes won't be enough. More over on RVPs ppl prefers to use Mock TPM to avoid the additional HW to boot the platform. For this reason we don't enable this Kconfig by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia959ae9072e3fc709b779b1fc778eb82e10c2ee3
Gerrit-Change-Number: 35103
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Aug 2019 02:36:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment