Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 42: device pci 15.2 on : end # I2C2 0xA0EA Turn off it?
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end Turn off it?
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC Delbin only support typec usb3. Do we need this?