Attention is currently required from: Ivan Chen, Nick Vaccaro, Paul Menzel, Shelley Chen, Sumeet R Pawnikar.
Eren Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81833/comment/ce6d8f70_32327b13 :
PS2, Line 9: Add fw_config field for storage to prevent depthcharge build break
Please mention the options, and add a dot/period at the end of sentences.
Done
File src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81833/comment/89c5e786_5672ec07 :
PS2, Line 3:
Remove extra tab. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 3
Gerrit-Owner: Eren Peng
peng.eren@inventec.corp-partner.google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Garen Wu
wu.garen@inventec.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rasheed Hsueh
hsueh.rasheed@inventec.corp-partner.google.com
Gerrit-CC: Steven Yeh
yeh.stevenct@inventec.corp-partner.google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Comment-Date: Wed, 17 Apr 2024 01:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment