Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31863 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2 ......................................................................
Patch Set 13:
(1 comment)
We have a Cherry-Pick only rule in our Gerrit setup. So no merging and every commit to be submitted has to apply to the master branch. That's not the case for this commit, currently, because half of the changes were in the other, abandoned commit. If you want to submit everything as one change, you'll have to squash the two commits into one. If you do, please retain the Change-Id of the second commit.
https://review.coreboot.org/#/c/31863/6/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31863/6/src/arch/x86/smbios.c@560 PS6, Line 560: && leaf_b.ecx == 0x0000 && leaf_b.edx == 0x0000) {
Sure the function can be added in futures patches, since this upgrade will be done in several steps. […]
Ah I missed that there are two cases of unsupported leafs. I don't know any database that would tell me since when leafs >=0xb are implemented. If we can't tell that for sure for all coreboot supported x86 processors (I think we have Pentium 2, still), we should implement both checks, I guess.