Attention is currently required from: Hannah Williams, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun Tuli.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76124?usp=email )
Change subject: soc/intel/meteorlake: Report CPU clock info
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
honestly i don;t see any value additional to print the CPU freq. […]
The ramstage print value can be max turbo or other max cpu frequency.
By using default CPU frquency and max turbo(max capable turbo frequency) we can get silicon sku info.
File src/soc/intel/meteorlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/76124/comment/3d3289ae_f01a33d1 :
PS5, Line 111: printk(BIOS_DEBUG, "CPU: Measured:%dMHz Max-Turbo:%dMHz\n",
Other lines use coma separated format: `CPU: Measured %luMHz, Max-Turbo: %luMHz` (also use correct f […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b056fb8db04eca345dd7a240d03463de7c59fc2
Gerrit-Change-Number: 76124
Gerrit-PatchSet: 6
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 28 Jun 2023 18:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Gerrit-MessageType: comment