[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/pmc: Add PMC API for low power programming

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45794 )

Change subject: soc/intel/common/block/pmc: Add PMC API for low power programming
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/... 
File src/soc/intel/common/block/pmc/Kconfig:

https://review.coreboot.org/c/coreboot/+/45794/6/src/soc/intel/common/block/... 
PS6, Line 36: 	  Enable this for PMC devices to perform registers programming
            : 	  to ensure low power in active idle scenario.
            :
> this is a lie

sorry didn't get you. system won't enter into s0ix if we don't bypass XTAL shutdown also keeping PCH PM timer enable has higher power penalty