Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 )
Change subject: security/tpm: add TPM log format as per 1.2 spec
......................................................................
Patch Set 10: Code-Review+2
(2 comments)
File src/security/tpm/tspi/log-tpm1.c:
https://review.coreboot.org/c/coreboot/+/68747/comment/fd3b77ba_c20d0fd1
PS10, Line 129: external
nit: "internal"?
File src/security/tpm/tspi/tspi.c:
https://review.coreboot.org/c/coreboot/+/68747/comment/930aa6cd_6a6d085a
PS10, Line 299: /* Below are wrappers that dispatch TPM log API to enabled implementation */
nit: these would probably make more sense as static inline functions in some header
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89720615a75573d44dd0a39ad3d7faa78f125843
Gerrit-Change-Number: 68747
Gerrit-PatchSet: 10
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 02 Mar 2023 02:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment