[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Implement power-failure-state handling

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34724 )

Change subject: soc/intel/common: Implement power-failure-state handling
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/34724/5/src/soc/intel/common/block/... 
PS5, Line 583: void pmc_set_power_failure_state(const pci_devfn_t dev)
Why does the caller need to provide a dev pointer here? SoC knows how to get to the GEN_PMCON* reg on its own i.e. MMIO or PCI config. And this function doesn't care about it anyways.