Attention is currently required from: Furquan Shaikh, Bernardo Perez Priego.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58215 )
Change subject: util/cse_serger: Add command `create-cse-region`
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File util/cbfstool/cse_serger.c:
https://review.coreboot.org/c/coreboot/+/58215/comment/1eef5c40_2e7bfdc6
PS3, Line 720: if (i == 0) {
braces {} are not necessary for any arm of this statement
Please fix.
https://review.coreboot.org/c/coreboot/+/58215/comment/3b99b73d_44dc5e77
PS3, Line 733: memcpy(buffer_get(&wbuff), buffer_get(&rbuff), buffer_size(&rbuff));
should the size of wbuff be verified?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58215
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib087f5516e5beb6390831ef4e34b0b067d3fbc8b
Gerrit-Change-Number: 58215
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 21:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment