22 Oct
2019
22 Oct
'19
1:03 a.m.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36179 )
Change subject: drivers/ipmi: Add IPMI BMC FRB2 watchdog timer support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_kcs.h File src/drivers/ipmi/ipmi_kcs.h:
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_kcs.h... PS5, Line 50: int ipmi_init_and_start_bmc_wdt(int port, uint16_t countdown,
please use a separate header for those high level functions
Should I only move the two function signatures to a new separate header (ipmi_ops.h) or should I also move all the added BMC WDG related codes to it? Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/36179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic91905e5f01b962473b6b3a9616266d2d95b1d6b
Gerrit-Change-Number: 36179
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks dhendrix.sync@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Sven Schnelle svens@stackframe.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Tue, 22 Oct 2019 08:03:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-MessageType: comment