[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable SATA depending on devicetree configuration

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43843 )

Change subject: soc/intel/skylake: Enable SATA depending on devicetree configuration
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/43843/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43843/4//COMMIT_MSG@7 
PS4, Line 7: soc/skylake: Enable SATA depending on devicetree configuration
> soc/intel/skylake

Done

https://review.coreboot.org/c/coreboot/+/43843/4/src/soc/intel/skylake/chip.... 
File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/43843/4/src/soc/intel/skylake/chip.... 
PS4, Line 170: dev ? dev->enabled : 0
> `dev && dev->enabled` is the canonical form to do this.

I would leave it like that to keep the consistency, since the existing code is handled like that.