Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85594?usp=email )
Change subject: arch/x86: Disable DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES ......................................................................
arch/x86: Disable DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES
Disable the debug code as there were unexplainable stack corruptions detected on some platforms.
No problems were observed on: - QEMU - Xeon-SP
Change-Id: I1f1b9f01af7fbb0c19becf6ea53d436898584c5e Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85594 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Subrata Banik subratabanik@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: Angel Pons: Looks good to me, but someone else must approve build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 2077405..7ef1a6d 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -377,8 +377,11 @@
config DEBUG_STACK_OVERFLOW_BREAKPOINTS_IN_ALL_STAGES bool - default y + default n depends on DEBUG_STACK_OVERFLOW_BREAKPOINTS && DEBUG_HW_BREAKPOINTS_IN_ALL_STAGES + help + Disabled as false-positive stack corruptions where observed on some platforms. + TODO: Investigate those reported errors before defaulting to yes.
# Some EC need an "EC firmware pointer" (a data structure hinting the address # of its firmware blobs) being put at a fixed position. Its space