Attention is currently required from: Angel Pons, Eric Lai.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83510?usp=email )
Change subject: device/pci_ids: Add new Intel PTL device IDs for UARTx
......................................................................
Patch Set 2:
(1 comment)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/83510/comment/957ef427_26112e80?usp... :
PS1, Line 3999: #define PCI_DID_INTEL_PTL_H_UART0 0xe425
: #define PCI_DID_INTEL_PTL_H_UART1 0xe426
: #define PCI_DID_INTEL_PTL_H_UART2 0xe452
: #define PCI_DID_INTEL_PTL_U_H_UART0 0xe325
: #define PCI_DID_INTEL_PTL_U_H_UART1 0xe326
: #define PCI_DID_INTEL_PTL_U_H_UART2 0xe352
nit: the alignment 😠[…]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83510?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I384a753f08ae5a752cef6009d07104e8ff4b4a6e
Gerrit-Change-Number: 83510
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 17 Jul 2024 16:11:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com