Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31851 )
Change subject: mb/google/hatch: Provide DRAM part number from EEPROM
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31851/4/src/mainboard/google/hatch/romstage....
File src/mainboard/google/hatch/romstage.c:
https://review.coreboot.org/#/c/31851/4/src/mainboard/google/hatch/romstage....
PS4, Line 57: *len = sizeof(part_num_store);
We don't care about it this being longer than actually used, right?
It is NULL-terminated string, so either ways it should be fine. I can change this to strlen to make it clear.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31851
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ade6999828b6d67aa78d04199138f195a97ba8c
Gerrit-Change-Number: 31851
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Mar 2019 16:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment