[coreboot-gerrit] Change in coreboot[master]: amd/picasso: rework USB2 PHY tune parameter handling

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43783 )

Change subject: amd/picasso: rework USB2 PHY tune parameter handling
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h 
File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h@... 
PS4, Line 139: USB_PORT_COUNT
> I wasn't sure if it would be a good idea to pull in the FspsUpd header here. […]

Agreed FSPS_UPD_USB2_PORT_COUTN should stay in FspsUpd.h. I was just wondering if we should reuse the same macro here. Anyways, we can go ahead with USB_PORT_COUNT.