Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62785 )
Change subject: soc/mediatek: Set soc_ops.set_resources as no-op ......................................................................
soc/mediatek: Set soc_ops.set_resources as no-op
Without setting the set_resources field for soc_ops, we will get an error during device initialization:
[ERROR] CPU_CLUSTER: 0 missing set_resources
Because the set_resources field is considered mandatory, explicitly set it as no-op noop_set_resources.
BUG=b:224419346 TEST=emerge-corsola coreboot TEST=Did not see the error on krabby BRANCH=none
Change-Id: Ic82b86f0482a9de09e942c1674be5f0ac615851f Signed-off-by: Yu-Ping Wu yupingso@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/62785 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/soc/mediatek/mt8173/soc.c M src/soc/mediatek/mt8183/soc.c M src/soc/mediatek/mt8186/soc.c M src/soc/mediatek/mt8192/soc.c M src/soc/mediatek/mt8195/soc.c 5 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Hung-Te Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8173/soc.c b/src/soc/mediatek/mt8173/soc.c index ef57130..7a4eeb6 100644 --- a/src/soc/mediatek/mt8173/soc.c +++ b/src/soc/mediatek/mt8173/soc.c @@ -21,6 +21,7 @@
static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };
diff --git a/src/soc/mediatek/mt8183/soc.c b/src/soc/mediatek/mt8183/soc.c index 6bcd4d0..c2e7d26 100644 --- a/src/soc/mediatek/mt8183/soc.c +++ b/src/soc/mediatek/mt8183/soc.c @@ -23,6 +23,7 @@
static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };
diff --git a/src/soc/mediatek/mt8186/soc.c b/src/soc/mediatek/mt8186/soc.c index 7686986..53e5065 100644 --- a/src/soc/mediatek/mt8186/soc.c +++ b/src/soc/mediatek/mt8186/soc.c @@ -32,6 +32,7 @@
static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };
diff --git a/src/soc/mediatek/mt8192/soc.c b/src/soc/mediatek/mt8192/soc.c index 006a212..cf1fe48 100644 --- a/src/soc/mediatek/mt8192/soc.c +++ b/src/soc/mediatek/mt8192/soc.c @@ -37,6 +37,7 @@
static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };
diff --git a/src/soc/mediatek/mt8195/soc.c b/src/soc/mediatek/mt8195/soc.c index 995aadc..cf9f412 100644 --- a/src/soc/mediatek/mt8195/soc.c +++ b/src/soc/mediatek/mt8195/soc.c @@ -43,6 +43,7 @@
static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };