Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44565 )
Change subject: mb/google/zork: Always populate 2 channels in Trembyle APCB ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44565/1/src/soc/amd/picasso/Makefil... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44565/1/src/soc/amd/picasso/Makefil... PS1, Line 398: x2 When APCB_POPULATE_2ND_CHANNEL != true, won't this make an SPD with just 1 channel? Isn't it misleading to call it _x2?
Should we just get rid of the suffix all together? The suffix was needed when the APCBs were generated by amd-picasso-fsp so we could pick the correct one. Now that we generate it as part of the build, I think we can remove the suffix.