Attention is currently required from: Alexander Couzens, Angel Pons, Martin L Roth, Nicholas Chin.
Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/79025?usp=email )
Change subject: nb/intel/haswell: Move SPD addresses to devicetree ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79025/comment/8c5cebdd_3f9bbaef?usp... : PS4, Line 14: Patch also covers recently added Z97 boards using Broadwell MRC.
IIRC autoport support for Haswell also landed recently, but this change doesn't seem to update autop […]
This is in a separate patch on this train.
Since it involves Go, the best I can do is emulate what you did for sandybridge. And since I cannot test because I have no Haswell boards, I prefer it be reviewed separately.
File src/northbridge/intel/haswell/broadwell_mrc/raminit.c:
https://review.coreboot.org/c/coreboot/+/79025/comment/51b86f99_b0380d0d?usp... : PS4, Line 377: struct spd_info spdi = {0}; : if (CONFIG(HAVE_SPD_IN_CBFS)) { : /* Obtain the SPD addresses from mainboard code */ : mb_get_spd_map(&spdi); : } else { : /* Boards without memory down: Obtain the SPD addresses from devicetree */ : memcpy(spdi.addresses, cfg->spd_addresses, ARRAY_SIZE(spdi.addresses)); : } :
Would be nice to avoid having this pattern repeated three times. […]
Nice idea, but the code are separate enough this helper function will need to go into a separate C file with all the overhead. In the end only one copy will get compiled into the binary. I can try it still.