Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74048 )
Change subject: mb/google/corsola: Add detachable Starmie as variant
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/74048/comment/d4367da5_11eefec8
PS10, Line 143: bridge->power_on
If all callbacks are required, can we check only `if (!bridge)`, and then use assertions for the cal […]
Sounds good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic1556ad0031e9a24bf26fa84d7713b7b7928312a
Gerrit-Change-Number: 74048
Gerrit-PatchSet: 11
Gerrit-Owner: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 02:59:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment