[coreboot-gerrit] Change in coreboot[master]: soc/intel/ehl: Remove PSE init 'magic code'

[Lean Sheng Tan (Code Review)]

Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63775 )

Change subject: soc/intel/ehl: Remove PSE init 'magic code'
......................................................................

soc/intel/ehl: Remove PSE init 'magic code'

Thanks to Werner's and the community presistancy & effort, Intel
has finally open sourced PSE FW!
https://github.com/intel/pse-fw

With this being done, hence removing the 'magic code' PSE configs
for FSP to run PSE initialization, as there are no document for
such config requirements.

Signed-off-by: Lean Sheng Tan 
Change-Id: I5cfacac62cae0a234e4c4927454311454ab01bdd
---
M src/soc/intel/elkhartlake/fsp_params.c
1 file changed, 0 insertions(+), 21 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/63775/1

diff --git a/src/soc/intel/elkhartlake/fsp_params.c b/src/soc/intel/elkhartlake/fsp_params.c
index 2100cc4..9d44bf5 100644
--- a/src/soc/intel/elkhartlake/fsp_params.c
+++ b/src/soc/intel/elkhartlake/fsp_params.c
@@ -181,27 +181,6 @@
    	params->PchPseAdcSbInterruptEnable = config->PseAdcSbIntEn;
    	params->PchPseLh2PseSbInterruptEnable = config->PseLh2PseSbIntEn;
    	params->PchPseShellEnabled = config->PseShellEn;
-
-		/*
-		 * As a minimum requirement for PSE initialization, the configuration
-		 * of devices below are required as shown.
-		 * TODO: Help needed to find a better way to handle this part of code
-		 * as the settings from devicetree are overwritten here.
-		 *
-		 * Set the ownership of these devices to PSE. These are hardcoded for now,
-		 * if the PSE should be opened one day (hopefully), this can be handled
-		 * much better.
-		 */
-		params->PchPseDmaEnable[0] = PSE_Owned;
-		params->PchPseUartEnable[2] = PSE_Owned;
-		params->PchPseHsuartEnable[2] = PSE_Owned;
-		params->PchPseI2cEnable[2] = PSE_Owned;
-		params->PchPseTimedGpioEnable[0] = PSE_Owned;
-		params->PchPseTimedGpioEnable[1] = PSE_Owned;
-		/* Disable PSE DMA Sideband Interrupt for DMA 0 */
-		params->PchPseDmaSbInterruptEnable[0] = 0;
-		/* Set the log output to PSE UART 2 */
-		params->PchPseLogOutputChannel = 3;
    } else {
    	die("PSE enabled but PSE FW not available!\n");
    }