Attention is currently required from: Elyes Haouas, Patrick Rudolph.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83386?usp=email )
Change subject: emulation/qemu-q35: Remove redefine TSEG_SZ_MASK
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/emulation/qemu-q35/romstage.c:
https://review.coreboot.org/c/coreboot/+/83386/comment/0b288e7d_ef453585?usp... :
PS1, Line 10: #define TSEG_SZ_MASK (3 << 1)
Hmmm. @patrick.rudolph@9elements.com added this here just recently. Any reason for that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83386?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ea08c18e1c41d16137ea14a1643f8c8d527722
Gerrit-Change-Number: 83386
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 10 Jul 2024 05:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes