Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42903 )
Change subject: mb/ocp/deltalake: Use VPD data to configure FSP UPD at romstage
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42903/2/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/42903/2/src/mainboard/ocp/deltalake...
PS2, Line 25: printk(BIOS_ERR, "Failed to get VPD %s, default set "
Such VPD not being said, is not really an error. Let's change BIOS_ERR to BIOS_INFO, and change "Failed to get" to "Not able to get".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b3463acedd90e8e17f7e4eedc2fab63644f87e1
Gerrit-Change-Number: 42903
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jul 2020 16:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment