[coreboot-gerrit] [M] Change in coreboot[master]: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config

[Eric Lai (Code Review)]

Attention is currently required from: Paul Menzel, Subrata Banik, Tarun Tuli.

Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75756?usp=email )

Change subject: arch/x86: Introduce DUMP_SMBIOS_TYPE17 config
......................................................................

Patch Set 5:

(2 comments)

File src/arch/x86/smbios.c:

https://review.coreboot.org/c/coreboot/+/75756/comment/4cfc2457_50bd4286 :
PS5, Line 263: 	if (code >= 0x01 && code <= 0x23)
             : 		return type[code - 0x01];
             : 	return "Unsupported memory type";
> WDYT? […]

Any improvement or help? TBH, I copied this function from dmi_decode upstream. And I am considering remove the DDR below DDR4.

https://review.coreboot.org/c/coreboot/+/75756/comment/6f21be40_3a91f294 :
PS5, Line 1046:
> i would have called below func from here […]

b/c this would need check many things if empty slot. so I add in create_smbios_type17_for_dimm. no need to print empty dimms.