Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44079 )
Change subject: mb/google/volteer/variant/lindar: Update gpio and devicetree settings ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44079/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44079/7/src/mainboard/google/voltee... PS7, Line 13: register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)" # USB3/2 Type A port A0
Please add a newline to seperate usb2 and usb3 setting.
Done
https://review.coreboot.org/c/coreboot/+/44079/7/src/mainboard/google/voltee... PS7, Line 17: register "SaGv" = "SaGv_Disabled"
Please add a newline to seperate the different setting.
Done
https://review.coreboot.org/c/coreboot/+/44079/7/src/mainboard/google/voltee... PS7, Line 64: device pci 15.2 on : chip drivers/i2c/sx9310 : register "desc" = ""SAR0 Proximity Sensor"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_F14_IRQ)" : register "speed" = "I2C_SPEED_FAST" : register "uid" = "0" : register "reg_prox_ctrl0" = "0x10" : register "reg_prox_ctrl1" = "0x00" : register "reg_prox_ctrl2" = "0x84" : register "reg_prox_ctrl3" = "0x0e" : register "reg_prox_ctrl4" = "0x07" : register "reg_prox_ctrl5" = "0xc6" : register "reg_prox_ctrl6" = "0x20" : register "reg_prox_ctrl7" = "0x0d" : register "reg_prox_ctrl8" = "0x8d" : register "reg_prox_ctrl9" = "0x43" : register "reg_prox_ctrl10" = "0x1f" : register "reg_prox_ctrl11" = "0x00" : register "reg_prox_ctrl12" = "0x00" : register "reg_prox_ctrl13" = "0x00" : register "reg_prox_ctrl14" = "0x00" : register "reg_prox_ctrl15" = "0x00" : register "reg_prox_ctrl16" = "0x00" : register "reg_prox_ctrl17" = "0x00" : register "reg_prox_ctrl18" = "0x00" : register "reg_prox_ctrl19" = "0x00" : register "reg_sar_ctrl0" = "0x50" : register "reg_sar_ctrl1" = "0x8a" : register "reg_sar_ctrl2" = "0x3c" : device i2c 28 on end : end : end # I2C2 0xA0EA
I don't think you have the proximity sensor, could you please double check this?
remove proximity sensor
https://review.coreboot.org/c/coreboot/+/44079/7/src/mainboard/google/voltee... PS7, Line 106: device pci 1f.3 on : chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A10)" : register "sdmode_delay" = "5" : device generic 0 on end : end : end # Intel HD audio
Are you using max98357a?
Thanks for reminding us, we exchange to use the Realtek ALC 1011 for the future. Remove this block of the max98357a. Waiting for a new schematic with ALC 1011, I will create a new issue/CL to update the device tree files.