Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34134 )
Change subject: cpu/x86: Declare SMM_ASEG
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34134/1/src/cpu/x86/Kconfig
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/34134/1/src/cpu/x86/Kconfig@96
PS1, Line 96: def_bool n
Simply using `bool` instead of `def_bool n` would avoid having
a `# CONFIG_SMM_ASEG is not set` in every (even non-x86) `.config`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9007c55c75a59a9e6acc0a0e701300f7d21f87
Gerrit-Change-Number: 34134
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 18:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment