Attention is currently required from: Tarun Tuli, Eran Mitrani.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 )
Change subject: mb/google/hatch: Add variant finalize support for hatch devices ......................................................................
Patch Set 13:
(1 comment)
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/68821/comment/1dd89076_8c3da99a PS13, Line 31: variant_finalize_gpio_table
Where is the code for this?
I found it. Should this call not be preceded by "variant_" given that it's only applicable to kohaku's ramstage.c? Usually the "variant_" routines are called from a common place (SoC or mainboard) and support a __weak function for variants that don't imnplement it. This variant_ routine appears to only be used in Kohaku by Kohaku.