Attention is currently required from: Tim Crawford, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Karthik Ramasubramanian.
Matt DeVillier has uploaded a new patch set (#4) to the change originally created by Raul Rangel. ( https://review.coreboot.org/c/coreboot/+/60174 )
Change subject: drivers/i2c/generic: Print error when using _CRS and PowerResource
......................................................................
drivers/i2c/generic: Print error when using _CRS and PowerResource
Exposing the GPIOs via an ACPI PowerResource and the _CRS results in the
OS driver and ACPI thinking they own the GPIO. This can cause timing
problems because it's not clear which system should be controlling the
GPIO. I'm making this an error because we should really clean these up.
BUG=b:210694108
TEST=Boot guybrush and see error:
I2C: 02:5d: ERROR: Exposing GPIOs in Power Resource and _CRS
_SB.I2C1.H05D: Goodix Touchscreen at I2C: 02:5d
Signed-off-by: Raul E Rangel rrangel@chromium.org
Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84
---
M src/drivers/i2c/generic/generic.c
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/60174/4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84
Gerrit-Change-Number: 60174
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: newpatchset