Attention is currently required from: chris wang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48733 )
Change subject: soc/amd/picasso: Add UPDs for support edp phy tuning adjust ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48733/comment/81157040_80fcac5e PS2, Line 7: soc/amd/picasso: Add UPDs for support edp phy tuning adjust Maybe:
Set UPDs for tuning eDP phy
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48733/comment/666607ff_b3af68e7 PS2, Line 60: /// dpphy_override Please use consistent commenting style in this file, which seems C89.
https://review.coreboot.org/c/coreboot/+/48733/comment/1deb85a3_adc9b3c9 PS2, Line 62: Plesae use one space, or be consistent with the rest (though I do not see the benefit of using two spaces.)
https://review.coreboot.org/c/coreboot/+/48733/comment/9df4ef83_0802ffca PS2, Line 238: uint8_t dp_phy_override; : uint16_t edp_phy_sel; : uint8_t edp_version; : uint16_t edp_table_size; : : struct { : uint8_t dp_vs_pemph_level; : uint8_t deemph_6db4; : uint8_t boostadj; : uint16_t margin_deemph; : } edp_tuningset; Please use one space as in the rest of the file.