Attention is currently required from: Felix Singer.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79543?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: mb/hp/snb_ivb_desktops: Make baseboard more generic ......................................................................
mb/hp/snb_ivb_desktops: Make baseboard more generic
In preparation to merging all the other HP sandy/ivy desktops in here as variants.
Move hda_verb.c, early_init.c, gma-mainboard.ads and data.vbt into variant directories.
Kconfig: Move options not common to the others under the variants instead.
devicetree: Move XHCI to variant overridetrees (8200 gen has no USB 3)
board_info: Make it more generic. It seems to be copied from 8200 SFF and inaccurate to Z220 anyway.
TEST: BUILD_TIMELESS=1, all the files in CBFS are identical, except config (since the VBT data file moved).
Change-Id: Icce22efb8d353359781db3f03c67058d8fbe11b8 Signed-off-by: Riku Viitanen riku.viitanen@protonmail.com --- M src/mainboard/hp/snb_ivb_desktops/Kconfig M src/mainboard/hp/snb_ivb_desktops/Makefile.inc M src/mainboard/hp/snb_ivb_desktops/board_info.txt M src/mainboard/hp/snb_ivb_desktops/devicetree.cb R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/data.vbt R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/early_init.c R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/gma-mainboard.ads R src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/hda_verb.c M src/mainboard/hp/snb_ivb_desktops/variants/z220_cmt_workstation/overridetree.cb C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/data.vbt C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/early_init.c C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/gma-mainboard.ads C src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/hda_verb.c M src/mainboard/hp/snb_ivb_desktops/variants/z220_sff_workstation/overridetree.cb 14 files changed, 23 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/79543/8