Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35588 )
Change subject: console: Declare empty printk() for __ROMCC__
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35588/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35588/2//COMMIT_MSG@11
PS2, Line 11:
You mean this patch doesn't work adequately because of the empty inline? Just #define prinkt(... […]
See CB:35616 where that 'do {} while (0)' increases romcc register usage. I am not quite sure why e.g. <arch/smp/spinlock.h> does not define empty macros if they would work everywhere?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb0c33b082b4c4453d29d917f46561c0e672d09a
Gerrit-Change-Number: 35588
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Sep 2019 17:27:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment