Attention is currently required from: Furquan Shaikh, Chiranjeevi Rapolu, John Zhao, Duncan Laurie, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51194 )
Change subject: soc/intel/tigerlake: Enable TCSS Muxes to disconnect mode during boot
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/51194/comment/9e04b787_e76fbc37
PS1, Line 322: mainboard_tcss_get_port_info
Aah that intent was definitely not clear from the callbacks. […]
There is a static helper function in ec_acpi.c that could be repurposed for this, `get_usb_port_references`. Right now, it stuffs out parameters with references to the `struct device *` USB2/3/4 ports for the given Type-C port; those references contain the port numbers in the `path` member (port_type == 2/3/4, and port_id is the 0-based port ID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4352072a4a7d6ccb1364b38377831f3c22ae8fb4
Gerrit-Change-Number: 51194
Gerrit-PatchSet: 1
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Duncan Laurie
dlaurie@gmail.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 23:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment