build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36091 )
Change subject: mb/intel/tglrvp: Do initial mainboard commit ......................................................................
Patch Set 9:
(10 comments)
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 1: config BOARD_INTEL_BASEBOARD_TGLRVP trailing whitespace
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/chromeos.c:
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 31: {-1, ACTIVE_HIGH, 0,"EC in RW"}, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 32: { 15, 8, 9, 14, 12, 11, 10, 13 }}, // Byte 1 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 34: { 3, 4, 7, 0, 6, 1, 5, 2 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 36: { 11, 10, 12, 13, 8, 9, 14, 15 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 38: { 4, 7, 3, 2, 1, 6, 0, 5 }}, // Byte 7 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 41: { 4, 5, 6, 7, 3, 2, 0, 1 }}, // Byte 1 ChB! space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 43: { 9, 8, 10, 11, 14, 15, 13, 12 }}, // Byte 3 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 45: { 10, 13, 12, 11, 14, 9, 15, 8 }}, // Byte 5 space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/36091/9/src/mainboard/intel/tglrvp/... PS9, Line 47: { 3, 4, 1, 2, 6, 0, 5, 7 }} // Byte 7 space required after that close brace '}'