[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/trulo/var/orisa: Fill in gpio.h for orisa

[Paul Menzel (Code Review)]

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Paul Menzel has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83155?usp=email )

Change subject: mb/google/trulo/var/orisa: Fill in gpio.h for orisa
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83155/comment/fc75fbbf_af591322?usp... :
PS2, Line 7: Fill in gpio.h for orisa
Please remove redundant “for orisa”.

https://review.coreboot.org/c/coreboot/+/83155/comment/bf4bf9a4_cc61d761?usp... :
PS2, Line 8: 
Please document the source for your changes.

File src/mainboard/google/brya/variants/orisa/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/83155/comment/b358243e_1e44add9?usp... :
PS2, Line 17: /* GPIO IRQ for tight timestamps */
What are tight timestamps?

https://review.coreboot.org/c/coreboot/+/83155/comment/5cd2d9de_8eff0b3b?usp... :
PS2, Line 19: /* GPP_H18 used as dummy here since nissa not selected HAVE_SLP_S0_GATE */
I do not understand the comment. Can you rephrase the problem with nissa?