Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52649 )
Change subject: soc/amd/cezanne: Update STAPM vars with units
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/52649/comment/371f216c_a723da31
PS2, Line 57: W
Same as the comment in the previous patch. […]
i'd keep the mixed case here to have the correct spelling of the units, but don't have a too strong opinion on this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I592c807c5e9a2c17b1c5959e56a01237352c5204
Gerrit-Change-Number: 52649
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 16:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment