Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48317 )
Change subject: soc/amd/cezanne: add config.c and minimal chip.h
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config....
File src/soc/amd/cezanne/config.c:
https://review.coreboot.org/c/coreboot/+/48317/1/src/soc/amd/cezanne/config....
PS1, Line 9: cfg
cfg is always non-NULL, so no need to re-check that here: config_of_soc calls config_of which calls […]
ah, common_config isn't a pointer, so no need to NULL-check it. I'll add a comment about the soc_get_config call though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89f08c201bd7d9a11b186ef960abe9714a76fb97
Gerrit-Change-Number: 48317
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 05 Dec 2020 17:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment