Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43488 )
Change subject: lib: Remove corrupted fmap cache error for psp_verstage ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43488/1/src/lib/fmap.c File src/lib/fmap.c:
https://review.coreboot.org/c/coreboot/+/43488/1/src/lib/fmap.c@60 PS1, Line 60: (ENV_SEPARATE_VERSTAGE && CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)))) {
What this line is really trying to say is "if we're not in the first stage that runs", which is a co […]
No, we do still want it to run in bootblock on zork. It gets generated in the PSP's memory by verstage, but that gets wiped out - we don't (currently) transfer the fmap cache, just the workbuf. If you think there's enough time savings to make it worthwhile to transfer the fmap cache from verstage to the x86, we could probably do it, but that wasn't previously on our list of things to transfer.
Even if we do add it to the list of buffers to transfer, we can't guarantee that it will get transferred. The only thing we're guaranteed enough space to transfer is the BKB resized workbuf. In practice, on the current generation of chips, we'll always have enough room unless we're working with the Sensor Fusion Hub processor (MP2) where we store the transfer buffer. On future chips that space probably won't be available.