Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41637 )
Change subject: sb/intel/i82371eb: Clean up PM register #defines ......................................................................
Patch Set 1:
(2 comments)
Seems to need a rebuild
https://review.coreboot.org/c/coreboot/+/41637/1/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/i82371eb.h:
https://review.coreboot.org/c/coreboot/+/41637/1/src/southbridge/intel/i8237... PS1, Line 57: //#define SUS_TYP_S2>---(2<<10) Hm?
https://review.coreboot.org/c/coreboot/+/41637/1/src/southbridge/intel/i8237... PS1, Line 100: /* Bit definitions */ Which register do these definitions apply to?