[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common/block/oc_wdt: Add OC watchdog common block

[Nico Huber (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Martin L Roth, Maximilian Brune, Michał Kopeć, Michał Żygowski, Werner Zeh.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68944?usp=email )

Change subject: soc/intel/common/block/oc_wdt: Add OC watchdog common block
......................................................................

Patch Set 17:

(1 comment)

File src/soc/intel/common/block/oc_wdt/oc_wdt.c:

https://review.coreboot.org/c/coreboot/+/68944/comment/a2d33ee7_25841cda :
PS17, Line 62: unsigned int oc_wdt_get_current_timeout(void)
             : {
             : 	return (inl(PCH_OC_WDT_CTL) & PCH_OC_WDT_CTL_TOV_MASK) + 1;
             : }
> Nico, the value in the register reflects the currently programmed timeout (so it is constant between […]

Thanks, I just misunderstood what "current" refers to. But now, I
understand the purpose of the function even less, I guess. Why would
someone read back the last programmer value? Is there some code that
is using it yet?