Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
(
25 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/arm: Add a few ARM targets as supported by CLANG ......................................................................
arch/arm: Add a few ARM targets as supported by CLANG
Some targets cannot be supported by clang as clang generates slightly larger binaries which the hardware won't accept. This is usually the case with CONFIG_CHROMEOS.
Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/69747 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/arm/Kconfig M src/soc/nvidia/tegra124/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig M src/soc/rockchip/rk3288/Kconfig 5 files changed, 8 insertions(+), 1 deletion(-)
Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/arch/arm/Kconfig b/src/arch/arm/Kconfig index 0829dcb..64fe915 100644 --- a/src/arch/arm/Kconfig +++ b/src/arch/arm/Kconfig @@ -2,7 +2,6 @@
config ARCH_ARM bool - select CLANG_UNSUPPORTED
config ARCH_BOOTBLOCK_ARM bool diff --git a/src/soc/nvidia/tegra124/Kconfig b/src/soc/nvidia/tegra124/Kconfig index 88877e9..5f967d2 100644 --- a/src/soc/nvidia/tegra124/Kconfig +++ b/src/soc/nvidia/tegra124/Kconfig @@ -14,6 +14,8 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER + # clang creates larger binaries that may not fit + select CLANG_UNSUPPORTED if CHROMEOS
if SOC_NVIDIA_TEGRA124
diff --git a/src/soc/qualcomm/ipq40xx/Kconfig b/src/soc/qualcomm/ipq40xx/Kconfig index 98c3a8e..e32f228 100644 --- a/src/soc/qualcomm/ipq40xx/Kconfig +++ b/src/soc/qualcomm/ipq40xx/Kconfig @@ -9,6 +9,8 @@ select ARCH_RAMSTAGE_ARMV7 select HAVE_UART_SPECIAL select GENERIC_GPIO_LIB +# clang creates larger binaries that may not fit + select CLANG_UNSUPPORTED if CHROMEOS
if SOC_QC_IPQ40XX
diff --git a/src/soc/qualcomm/ipq806x/Kconfig b/src/soc/qualcomm/ipq806x/Kconfig index b9e47e5..22a2155 100644 --- a/src/soc/qualcomm/ipq806x/Kconfig +++ b/src/soc/qualcomm/ipq806x/Kconfig @@ -10,6 +10,8 @@ select HAVE_UART_SPECIAL select GENERIC_GPIO_LIB select NO_MONOTONIC_TIMER +# clang creates larger binaries that may not fit + select CLANG_UNSUPPORTED if CHROMEOS
if SOC_QC_IPQ806X
diff --git a/src/soc/rockchip/rk3288/Kconfig b/src/soc/rockchip/rk3288/Kconfig index a51df2a..7036bbb 100644 --- a/src/soc/rockchip/rk3288/Kconfig +++ b/src/soc/rockchip/rk3288/Kconfig @@ -18,6 +18,8 @@ select NO_BOOTBLOCK_CONSOLE select NO_FMAP_CACHE select NO_CBFS_MCACHE +# clang creates larger binaries that may not fit + select CLANG_UNSUPPORTED if CHROMEOS
if SOC_ROCKCHIP_RK3288