Attention is currently required from: Daniel Peng, Eric Lai, Kapil Porwal, Nick Vaccaro, Shawn Ku.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80742?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/glassway: Initialize devicetree setting
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80742/comment/15adbfc7_661e1413 :
PS3, Line 7: Initialize devicetree setting
Maybe:
Add initial override devicetree
https://review.coreboot.org/c/coreboot/+/80742/comment/8b505841_ad10351a :
PS3, Line 10: schematic
Please document the revision.
https://review.coreboot.org/c/coreboot/+/80742/comment/19d04f3f_a6f5ecfb :
PS3, Line 14: TEST=None
Because you do not have a prototype yet?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80742?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibbb10a373bd5fa52a0833b81133517d2a088536b
Gerrit-Change-Number: 80742
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 26 Feb 2024 12:27:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment