Attention is currently required from: Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Usha P.
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61439 )
Change subject: mb/google/brya: Add memory config for nissa
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/memory.c:
https://review.coreboot.org/c/coreboot/+/61439/comment/3ed69cc3_d8dadce1
PS1, Line 73: BOARD_TYPE_MOBILE
Krishna, do you know how this should be set? I couldn't find any info on it.
You can look here, https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/hea...
We can leave it as Mobile I believe.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6958c7b74851879dbea41d181ef8f1282bf0101d
Gerrit-Change-Number: 61439
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Fri, 28 Jan 2022 07:07:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment