Attention is currently required from: Hung-Te Lin, Furquan Shaikh, Marc Jones, Ricardo Quesada, Julius Werner.
Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56904 )
Change subject: include/bcd: move bcd code to commonlib/bsd/include
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes, let's get an approval from the original author. […]
I think it's OK since as Ricardo mentions, this code existed in mosys under a BSD license before coreboot (going back to 2012).... at least the bin2bcd part.
I'm no lawyer tho, so may be best to wait.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56904
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If2eba82da35838799bcbcf38303de6bd53f7eb72
Gerrit-Change-Number: 56904
Gerrit-PatchSet: 1
Gerrit-Owner: Ricardo Quesada
ricardoq@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Attention: Ricardo Quesada
ricardoq@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 11 Aug 2021 15:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment