Attention is currently required from: Nick Vaccaro, Pavan Holla, Shelley Chen.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled
......................................................................
Patch Set 7: Code-Review-1
(1 comment)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/81967/comment/3f5618fd_f79f6180 :
PS7, Line 427: CBI_COMMON_CONTROL_UCSI_ENABLED
this bit position needs to be derived from ec_commands.h
otherwise we have to way to correlate the coreboot vs EC
implementation.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81967?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67dff6445aa7ba3ba48a04d1df3541f880d09d0a
Gerrit-Change-Number: 81967
Gerrit-PatchSet: 7
Gerrit-Owner: Pavan Holla
pholla@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Forest Mittelberg
bmbm@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Pavan Holla
pholla@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 18 Apr 2024 20:03:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment