Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46821 )
Change subject: cpu/x86/mpinit/sipi_vector: Move code to C
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46821/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46821/1//COMMIT_MSG@8
PS1, Line 8:
What is the problem or motivation for the change?
https://review.coreboot.org/c/coreboot/+/46821/1/src/cpu/x86/sipi_vector_c_h...
File src/cpu/x86/sipi_vector_c_handler.c:
https://review.coreboot.org/c/coreboot/+/46821/1/src/cpu/x86/sipi_vector_c_h...
PS1, Line 87: /* Enable sse instructions. */
Remove the (unneeded) dot/period at the end – also for consistency with the other comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6c2ffa2ce8c42eee9f3fe8ec8cff933942207ca
Gerrit-Change-Number: 46821
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Oct 2020 08:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment