Attention is currently required from: Julius Werner, Martin L Roth.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84431?usp=email )
Change subject: sconfig: Move config_of_soc from device.h to static.h
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
unresolved
Done
File src/include/device/devicetree.h:
PS1:
This name is going to get very confusing with <commonlib/device_tree.h>. […]
Acknowledged. I simply moved config_of_soc directly into static.h without creating a new header as it's just a single line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84431?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c40135bf2815093b81e47201c38b7d0a6ac8fa8
Gerrit-Change-Number: 84431
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 21 Sep 2024 01:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com