Attention is currently required from: Edward O'Callaghan, Angel Pons. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62809 )
Change subject: mb/hp/z220_series: Add Z220 CMT Workstation variant ......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3: Hoping this is good to go.
File src/mainboard/hp/z220_series/variants/z220_cmt_workstation/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62809/comment/7ae8c49c_855d7fa5 PS3, Line 5: subsystemid 0x103c 0x1791 inherit
Is this needed? It's the same as on the devicetree
As per previous commit, yes this line is required to continue the inheritance of the subsystemids.
https://review.coreboot.org/c/coreboot/+/62809/comment/3c2a1bee_1ebb16ac PS3, Line 8:
nit: some blank lines could be dropped
meh