Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt ......................................................................
device/device.h: Drop acpi_inject_dsdt
This is now unused in the tree and filling SSDT should always be used.
TEST=intel/archercity CRB
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78334 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/acpi/acpi.c M src/include/device/device.h 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: Patrick Rudolph: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 0bd82cb..0e4798c 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1362,9 +1362,6 @@ if (CONFIG(CHROMEOS_NVS)) acpi_fill_cnvs();
- for (const struct device *dev = all_devices; dev; dev = dev->next) - if (dev->ops && dev->ops->acpi_inject_dsdt) - dev->ops->acpi_inject_dsdt(dev); current = (unsigned long)acpigen_get_current(); memcpy((char *)current, (char *)dsdt_file + sizeof(acpi_header_t), diff --git a/src/include/device/device.h b/src/include/device/device.h index 1387051..cd0999a 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -56,7 +56,6 @@ unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); void (*acpi_fill_ssdt)(const struct device *dev); - void (*acpi_inject_dsdt)(const struct device *dev); const char *(*acpi_name)(const struct device *dev); /* Returns the optional _HID (Hardware ID) */ const char *(*acpi_hid)(const struct device *dev);