Attention is currently required from: Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47098 )
Change subject: sb/intel/lynxpoint: Correct read width in RMW cycle
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47098/comment/554b751d_c22cfedd
PS4, Line 70: reg32 = pci_read_config32(dev, 0x98);
This was likely done on purpose to not clear bits [16:32]. […]
IIRC, I checked reference code and it does a 32-bit read. I'll check again and update the commit message accordingly (say "reference code version F.O.O does this" or similar).
Until then, I'm leaving this as unresolved
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18fbba0603579417e09ae4eb4eb273f7fcd903fc
Gerrit-Change-Number: 47098
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 03 Feb 2021 09:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment