[coreboot-gerrit] Change in coreboot[master]: amd/picasso: rework USB2 PHY tune parameter handling

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43783 )

Change subject: amd/picasso: rework USB2 PHY tune parameter handling
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h 
File src/soc/amd/picasso/chip.h:

https://review.coreboot.org/c/coreboot/+/43783/4/src/soc/amd/picasso/chip.h@... 
PS4, Line 139: USB_PORT_COUNT
> Just curious: Can't we directly use `FSPS_UPD_USB2_PORT_COUNT` here?

I wasn't sure if it would be a good idea to pull in the FspsUpd header here. FSPS_UPD_USB2_PORT_COUNT should definitely stay in FspsUpd.h