Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 29:
(7 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/087eba2e_5e9f8e2e PS29, Line 247: { NULL, ITE_SMFI, PNP_IRQ0, 0xfff0, }, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/40b50dda_13753166 PS29, Line 250: /* Power Mangement I/F Channel 1 (PMC1) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/1f2c0383_8978e8c5 PS29, Line 252: /* Power Mangement I/F Channel 2 (PMC2) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/f1d6956a_09a3d272 PS29, Line 258: /* Power Mangement I/F Channel 3 (PMC3) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/1f2b2904_7222fa8b PS29, Line 260: /* Power Mangement I/F Channel 4 (PMC4) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/1c12903b_c8e3a509 PS29, Line 262: /* Power Mangement I/F Channel 5 (PMC5) */ 'Mangement' may be misspelled - perhaps 'Management'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133032): https://review.coreboot.org/c/coreboot/+/58343/comment/0dec4382_dbbfabc3 PS29, Line 274: }; adding a line without newline at end of file